[Bug 37716] New: GTAVC in virtual desktop starts minimized

classic Classic list List threaded Threaded
40 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[Bug 37716] New: GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

            Bug ID: 37716
           Summary: GTAVC in virtual desktop starts minimized
           Product: Wine
           Version: 1.7.32
          Hardware: x86
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: directx-d3d
          Assignee: [hidden email]
          Reporter: [hidden email]
      Distribution: ---

After wine upgrade launching GTAVC in wine virtual desktop doesn't show
anything on screen of the virtual desktop. I can hear sound from intro video
though. In fact, I can click on the GTAVC icon at the bottom-left, then a menu
appears, selecting "Restore" in which gives me the game window and allows
playing.

Here's the git-bisect result

45d530461bf29c953f5f4532cc0e917b4c4fc296 is the first bad commit
commit 45d530461bf29c953f5f4532cc0e917b4c4fc296
Author: Stefan Dösinger <[hidden email]>
Date:   Thu Nov 13 20:39:25 2014 +0100

    wined3d: Minimize device windows on focus loss.

:040000 040000 7711e853d780f4c05cc8ae578ff45462fb9ec7f7
63f0b55f65e85a8895ac0d1ef0ee94dbb5595db6 M      dlls

PS: I'm using glib-2.30 with wine, so I can watch/hear the intro videos. I
think similar problem would be for those with new glib and disabled wine-gst.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

Ruslan Kabatsayev <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |regression
    Regression SHA1|                            |45d530461bf29c953f5f4532cc0
                   |                            |e917b4c4fc296

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

Ruslan Kabatsayev <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

Sebastian Lackner <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Sebastian Lackner <[hidden email]> ---
Could you try with 1.7.33 please? This might be similar to
https://bugs.winehq.org/show_bug.cgi?id=37658, where a fix was already
committed.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #2 from Ruslan Kabatsayev <[hidden email]> ---
(In reply to Sebastian Lackner from comment #1)
> Could you try with 1.7.33 please? This might be similar to
> https://bugs.winehq.org/show_bug.cgi?id=37658, where a fix was already
> committed.

In fact I caught the problem in 1.7.33 in the first place, and it's the bisect
which resulted in a commit between 1.7.31 and 1.7.32, so I set this version in
the report. So no, it's definitely not fixed yet.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

hash <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #3 from hash <[hidden email]> ---
It appears that same commit is impacting "World of Tanks".
It looks like the main problem happens with focus receive/loss.
With git wine after "World of Tanks" starts, f I switch to any other window and
then back to "World of Tanks", the game looks like its frozen and if I try to
input something it doesn't show anything but as soon I look back at that
"other" window I can see all the input I tried to input in "World of Tanks".
"World of Tanks" have a focus detection and if game detects that it lost the
focus it stops receiving any input.
So my guess is that with this commit after loosing focus game nether regain it.

I did git-bisect and got the same result as topic starter.
As off now this commit doesn't reverse-applies clearly:
The Hunk in dlls/wined3d/swapchain.c
but that doesn't stop wine from compiling and/or running without this problem.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #4 from Stefan Dösinger <[hidden email]> ---
I'm on vacation right now, I'll look at it next week.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #5 from Stefan Dösinger <[hidden email]> ---
By the way: Please state which OS and window manager you are using. It
shouldn't matter too much for the virtual desktop, but one never knows...

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #6 from Ruslan Kabatsayev <[hidden email]> ---
(In reply to Stefan Dösinger from comment #5)
> By the way: Please state which OS and window manager you are using. It
> shouldn't matter too much for the virtual desktop, but one never knows...

I'm using Kwin (KDE's window manager) in Linux.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #7 from hash <[hidden email]> ---
Gentoo, x86_64, gentoo-sources-3.18.0, sys-devel/gcc-4.8.3,
sys-libs/glibc-2.20, x11-wm/compiz-0.8.8 and xfce-base/xfwm4-4.11.2, tested in
both WM's.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #8 from Stefan Dösinger <[hidden email]> ---
I can't reproduce the problem with GTA Vice City (I assume that's what GTAVC
means) in a virtual desktop. I have to click anywhere in the desktop once to
cancel the non-playing intro video, but I never have a minimized window. I also
tested this without the focus loss minimization call, it shows the same
behavior.

hash, can you file a separate bug for the World of Tanks problem?

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #9 from Ruslan Kabatsayev <[hidden email]> ---
(In reply to Stefan Dösinger from comment #8)
> I can't reproduce the problem with GTA Vice City (I assume that's what GTAVC
> means) in a virtual desktop. I have to click anywhere in the desktop once to
> cancel the non-playing intro video, but I never have a minimized window. I
> also tested this without the focus loss minimization call, it shows the same
> behavior.
OK, I'll try to retest with current glib so that the video would not be played.
Maybe it's because of the video window or whatever.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #10 from Stefan Dösinger <[hidden email]> ---
That's a reasonable guess. I'll see if I can make the video play here.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #11 from Ruslan Kabatsayev <[hidden email]> ---
Indeed, disabling gstreamer and using current glib makes the game not minimized
at startup. So looks like the video window is the bug trigger.

P.S. to make the video playable, you'd have to compile glib-2.30 or earlier and
also gstreamer with plugins (plugins-bad, if I'm not mistaken) against this
glib.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

Béla Gyebrószki <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #12 from Béla Gyebrószki <[hidden email]> ---
The demo for Ghost Recon Advanced Warfighter 2 can be used to reproduce the
regression caused by commit 45d530461bf29c953f5f4532cc0e917b4c4fc296.

http://www.gamershell.com/download_19955.shtml

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #13 from Stefan Dösinger <[hidden email]> ---
I can reproduce the problem with Ghost Recon Advanced Warfighter 2. The game
minimizes before showing the intro videos.

The game destroys a window that is not the device window nor focus window after
setting up the device. I assume the window is the splash screen window that is
shown during the loading process. When the window is destroyed, Wine sets the
window focus to the device (== focus) window. Unfortunately
set_foreground_window first sets the active window to NULL, which sends
WM_ACTIVATEAPP(wparam = 0), and then sets it to the device/focus window, which
sends WM_ACTIVATEAPP(wparam = 1).

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #14 from Stefan Dösinger <[hidden email]> ---
The focus change behavior in user32 is correct in this case (old and new window
are owned by different threads). What's probably wrong is that a window != the
focus window has the focus in this situation.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #15 from Stefan Dösinger <[hidden email]> ---
Created attachment 50351
  --> https://bugs.winehq.org/attachment.cgi?id=50351
user32: Call SetActiveWindow in SetWindowPos instead of  SetForegroundWindow.

Please give this patch a try. It fixes graw2 for me, both inside a virtual
desktop and with KDE. I didn't get gstreamer working yet, so I can't test GTA
VC.

From the patch description:

Graw2 has a thread t1 owning a window w1 that is used as device and
focus window for d3d. That makes w1 the active window for t1 and the
global foreground window. Another thread t2 owns window w2, created
before w1. w2 is used as a loading splash window. After creating the
d3d device, w2 is repositioned with SetWindowPos(SWP_SHOWWINDOW) to
match the d3d device's resolution.

Currently this SetWindowPos call makes w2 the foreground window. A while
later w2 is destroyed, and the foreground window switches to w1. This
switch (correctly) generates two WM_ACTIVATEAPP messages and the first
of them causes wined3d to minimize the device window w1.

The SetWindowPos call also happens on Windows, but the splash screen is
only seen after device creation with Aero disabled.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #16 from Ruslan Kabatsayev <[hidden email]> ---
(In reply to Stefan Dösinger from comment #15)

> Please give this patch a try. It fixes graw2 for me, both inside a virtual
> desktop and with KDE. I didn't get gstreamer working yet, so I can't test
> GTA VC.

Doesn't change anything for GTA:VC.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.

Reply | Threaded
Open this post in threaded view
|

[Bug 37716] GTAVC in virtual desktop starts minimized

Wine - Bugs mailing list
In reply to this post by Wine - Bugs mailing list
https://bugs.winehq.org/show_bug.cgi?id=37716

--- Comment #17 from Ruslan Kabatsayev <[hidden email]> ---
I've made a tarball with binaries of glib-2.30 and some version of gstreamer,
so that you could test GTA:VC with it. Here's the tarball (22M archive):
http://www.filedropper.com/glib-230tar

To setup and test, I've tested it on Ubuntu with the following operations:

0. Download it to ~/Downloads
1. Execute:

cd /tmp # important!
tar xf ~/Downloads/glib-2.30.tar.bz2
ln -sv glib-2.30/lib/gstreamer-0.10/ .
# I've hacked libgstreamer-0.10.so to look into /tmp/gstreamer-0.10/ for
plugins, so these commands set up these temporary libs without needing root

2. Run GTA:VC like this

cd ~/opt/Games/Grand\ Theft\ Auto\ -\ Vice\ City
LD_LIBRARY_PATH=/tmp/glib-2.30/lib/ wine explorer /desktop=gvc,1280x1024
gta-vc.exe


There'll likely be some warnings on the console about symbols not found, but
these are not critical for the video format GTAVC uses, and I reproduce the bug
with current wine and correct work with previous wine versions.

--
Do not reply to this email, post in Bugzilla using the
above URL to reply.
You are receiving this mail because:
You are watching all bug changes.


12