kernel: Fix [Bug:1885] - LoadLibraryA("name ")

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

kernel: Fix [Bug:1885] - LoadLibraryA("name ")

Vitaliy Margolen
What's interesting this works only on winnt+. Win9x gives error
ERROR_DLL_NOT_FOUND.
I've ran some tests to find where it does this. It's done in the kernel32 not
ntdll. And ntdll fails in the same way as wine's does.

Vitaliy Margolen

changelog:
  kernel:
  - LoadLibrary should ignore trailing spaces in the library name.


kernel_load_lib.diff (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: kernel: Fix [Bug:1885] - LoadLibraryA("name ")

Vitaliy Margolen-2
Any reason why this patch didn't go in? It does fix the reported bug and tests
show the correct behavior.

Vitaliy Margolen

Monday, October 10, 2005, 3:14:24 PM, Vitaliy Margolen wrote:

> What's interesting this works only on winnt+. Win9x gives error
> ERROR_DLL_NOT_FOUND.
> I've ran some tests to find where it does this. It's done in the kernel32 not
> ntdll. And ntdll fails in the same way as wine's does.

> Vitaliy Margolen

> changelog:
>   kernel:
>   - LoadLibrary should ignore trailing spaces in the library name.




Reply | Threaded
Open this post in threaded view
|

Re: kernel: Fix [Bug:1885] - LoadLibraryA("name ")

Alexandre Julliard
Vitaliy Margolen <[hidden email]> writes:

> Any reason why this patch didn't go in? It does fix the reported bug and tests
> show the correct behavior.

You should only make a copy of the name when really necessary, to
avoid penalizing the common case.

--
Alexandre Julliard
[hidden email]